-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add single, comparison, diff tabs to heatmap page #1672
Conversation
size-limit report 📦
|
Codecov ReportBase: 66.68% // Head: 66.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
- Coverage 66.68% 66.18% -0.50%
==========================================
Files 156 166 +10
Lines 5285 5457 +172
Branches 1208 1227 +19
==========================================
+ Hits 3524 3611 +87
- Misses 1755 1840 +85
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/create-server |
const subtractedProfile = | ||
exemplarsSingleView.profile && | ||
exemplarsSingleView.selectionProfile && | ||
subtract(exemplarsSingleView.profile, exemplarsSingleView.selectionProfile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit, but I would call it outer
or difference
(borrowing from set theory).
Subtraction was the method we used to get the result, but it's not the defying characteristic of that data IMO.
To give a stupid example, imagine following code
const herAge = 30;
const hisAge = 20;
What would we call herAge - hisAge
? subtractedAge
or ageDifference
? Latter express the relationship much better IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great call !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a small comment, but nothing major.
For comparison tab have a few styling tweaks. I do think it's hard to understand what's going on to someone who is new to the page so I added a couple of elements to hopefully help with that. We can continue to refine these over time, but for now:
|
/create-server |
Brief
Changes
demo link: https://pr-1672.pyroscope.io/exemplars/single?query=rideshare-app-golang.cpu%7B%7D
Screen.Recording.2022-11-09.at.15.14.12.mov
adhoc tabs
Concerns