-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize cache persistence #385
Conversation
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 49.52% 49.51% -0.01%
==========================================
Files 121 124 +3
Lines 5499 5608 +109
==========================================
+ Hits 2723 2776 +53
- Misses 2508 2568 +60
+ Partials 268 264 -4
Continue to review full report at Codecov.
|
1b6dbdf
to
5a9f9d9
Compare
whoa, that memory drop is impressive! (placeholder for after I read the code) Re: 9, can you update the dashboard in monitoring/lib and |
Sure thing, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, merging
Update grafana image references to :main
The PR includes number of improvements:
cache.GetOrCreate
.pyroscope_storage_cache_hits_total
- the way cache lookup is implemented this metric would require quite a dirty code branch. Meanwhile the metric value can be derived frompyroscope_storage_cache_misses_total
.pyroscope_storage_cache_persisted_total
counter replaced with histograms:pyroscope_storage_cache_disk_writes
pyroscope_storage_cache_disk_reads
Performance implications
One of the main goal was to decrease pyroscope server resource consumption:
Notably that GC is not a problem anymore: