-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 support #63
Python 3 support #63
Conversation
Ah unfortunate that this fails |
It succeeds just fine when pyroscope/pyrobase#6 is installed |
b6dbcb1
to
40aec5e
Compare
src/pyrocore/scripts/rtxmlrpc.py
Outdated
@@ -236,7 +236,7 @@ def do_import(self): | |||
script_text = sys.stdin.read() | |||
|
|||
with tempfile.NamedTemporaryFile(suffix='.rc', prefix='rtxmlrpc-', delete=False) as handle: | |||
handle.write(script_text) | |||
handle.write(script_text.encode()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make 'utf-8' explicit, because Python2 differs.
2a35e67
to
1e3dad3
Compare
7f1766d
to
e74cb42
Compare
To fix some of the current issues, I added:
on my local that makes |
Also, came up with a few fixes to https://gist.github.com/Amar1729/9500b8878f1f90546bf32e1414534553 |
I appreciate the update, but most importantly though @pyroscope's source is canonical, I don't want my fork to be hardcoded anywhere. |
Any word on this? It's literally the last library I use that doesn't support py3, and I'm at the point where I no longer use py2 anymore. |
pyrobase first, which is almost done. |
@kannibalox BTW, I decided – unlike with pyrobase – to go immediately Python 3.6+ only after the 1.0 release, which will make things a lot more streamlined in the short and long term. Please keep this open for visibility and applying relevant parts of your work / patches. |
I missed updating the metadata to reflect it, but I'm using this code on version 3.6.9. Thanks for all the work you've put in, I'll definitely keep this open. |
Depends on pyroscope/pyrobase#6
Notes:
update-to-head.sh
is broken due topaver -q develop -U
trying to install the non-py3 pyrobase