Replace expect with a safer alternative that returns None instead
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the fact that this function returns a `Result`, in case of a failure, the function should either return an `Err` or silent fail. When using `expect`, the program just panics, so none of the above situations happen. I have replaced `expect` with `and_then`. Now the code silent fails in case time before UNIX epoch is not supported, returning `None` instead. Signed-off-by: Costin-Robert Sin <sin.costinrobert@gmail.com>
|
LGTM. Thanks @costinsin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the fact that this function returns a
Result, in case of a failure, the function should either return anError silent fail.When using
expect, the program just panics, so none of the above situations happen.I have replaced
expectwithand_then. Now the code silent fails in case time before UNIX epoch is not supported, returningNoneinstead.