Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: natively support Graph in all Join Counts statistics #295

Merged
merged 8 commits into from
Jul 20, 2024

Conversation

martinfleis
Copy link
Member

Adding a native support to all Join Counts classes.

This uncovered two bugs in libpysal, one in eliminate_zeros and other in isolates. I have fixes for both locally, a PR is coming. Marking this as a draft until these land in lib.

esda/join_counts.py Outdated Show resolved Hide resolved
@martinfleis
Copy link
Member Author

Dev is green 🎉

@martinfleis martinfleis marked this pull request as ready for review July 19, 2024 19:44
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.7%. Comparing base (3ffe8ed) to head (b62070d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #295     +/-   ##
=======================================
+ Coverage   80.7%   80.7%   +0.1%     
=======================================
  Files         24      24             
  Lines       3239    3269     +30     
=======================================
+ Hits        2613    2639     +26     
- Misses       626     630      +4     
Files Coverage Δ
esda/join_counts.py 97.4% <92.9%> (-0.7%) ⬇️
esda/join_counts_local.py 98.2% <90.9%> (-1.8%) ⬇️
esda/join_counts_local_bv.py 98.8% <92.3%> (-1.2%) ⬇️
esda/join_counts_local_mv.py 98.2% <90.9%> (-1.8%) ⬇️

@knaaptime knaaptime self-requested a review July 19, 2024 20:05
@jGaboardi
Copy link
Member

  • CI is all green - libpysal is pinned - we have approvals
  • I'll merge tomorrow in the AM unless someone else already has or there are detractors

@jGaboardi jGaboardi merged commit b183177 into pysal:main Jul 20, 2024
14 checks passed
@martinfleis martinfleis deleted the join-counts-graph branch July 20, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants