Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formats, lints, pytest pt. 2 -- test_adbscan.py #343

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

jGaboardi
Copy link
Member

This PR:

  • formats, lints, and migrates to pytest
    • test_adbscan.py

xref:

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.3%. Comparing base (faff9fd) to head (987d123).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #343   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files         24      24           
  Lines       3331    3331           
=====================================
  Hits        2709    2709           
  Misses       622     622           

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do this in one or two PRs, no need to split by file. It is all pretty generic find and replace (in principle).

@martinfleis martinfleis merged commit 0388ad2 into pysal:main Jul 21, 2024
14 checks passed
@jGaboardi
Copy link
Member Author

jGaboardi commented Jul 21, 2024

I think you can do this in one or two PRs, no need to split by file. It is all pretty generic find and replace (in principle).

You say that now, but these first two are the super easy ones. There are several that are monsters. LOL

But I will keep that in mind and cluster the remaining easy ones together into 1 batch.

@jGaboardi jGaboardi deleted the GH335__part_2__adbscan branch July 21, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants