-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: convert unittests to pytest #601
Conversation
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
=======================================
+ Coverage 0 83.9% +83.9%
=======================================
Files 0 127 +127
Lines 0 14804 +14804
=======================================
+ Hits 0 12420 +12420
- Misses 0 2384 +2384
|
@@ -18,8 +18,8 @@ | |||
|
|||
|
|||
@skipIf(GEOPANDAS_EXTINCT, "Geopandas is missing, so test will not run.") | |||
class Test_Alpha_Shapes(TestCase): | |||
def setUp(self): | |||
class Test_Alpha_Shapes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also occasionally sorted imports with ruff and changed
Test_Rook
toTestRook
to make ruff happy but not consistently.
So are we OK with underscored class names for now or in general? I have no problem with "for now," especially not in this PR, but probably we'll want to take care of that soon. And I can loop that in with #589.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change private bits like tests. We can have a discussion about public but I would probably keep those intact to avoid unnecessary deprecations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinfleis Absolutely amazing. Never heard of pytestify
.
Neither did I until today 😄. It is not perfect but goes a long way. |
Closes #595
Mostly done automagically using
pytestify
with some of manual fixes. I also occasionally sorted imports with ruff and changedTest_Rook
toTestRook
to make ruff happy but not consistently.I have removed all optional skips based on missing pandas, geopandas or shapely since all are hard dependencies now.