-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting via ruff
#662
Formatting via ruff
#662
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=====================================
Coverage 85.0% 85.0%
=====================================
Files 139 139
Lines 14889 14889
=====================================
Hits 12663 12663
Misses 2226 2226
|
Do we want to switch to ruff-format? I think it deserves some discussion. I am all for it. When doing that in |
I am also all for it after realizing how simple the switch was, but also agree that we might want a broader discussion and approval. Shall we open an actual issue for this (and keep this PR open), or have more of a discussion in here? |
I think it is fine to have it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving a formal approval to show my support.
interesting, hadnt seen xvec. We started doing something like that when geosnap started, but it became clear quickly that a long-form geodataframe was far better in our case (since vectors often have different geoms in different time slices...) anyway, another tangent :) fine with the switch. I use the ruff extension in vscode locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Simplifying the environment is always a good enhancement.
@knaaptime Can you hit approve to make it more "formal?" 🤵♂️ |
Nows this PR has 3 approvals. @gegen07 @knaaptime @martinfleis Shall we wait another week or so to see if anyone else has opinions? I am perfectly fine taking even longer to make sure we aren't being too hasty. |
There's no rush. I'd wait for the next dev call next week. |
The dev team in attendance at the 2023-12-7 meeting voted in favor of this implementation. Shall we go ahead and merge now or would it be better to wait longer? |
This PR:
xarray-contrib/xvec
for swapping outblack
forruff format
in formattingpyproject.toml
of thisdocs/install
for supported Python versionsxref #589