Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around GEOS issue in voronoi_frames #693

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

martinfleis
Copy link
Member

While using the new voronoi_frames on a fairly large dataset, I noticed this issue libgeos/geos#1062 plus another where some polygons coming from GEOS were not actually valid, likely due to the same reason. This is a workaround that solves all I faced.

@martinfleis martinfleis self-assigned this Mar 25, 2024
@martinfleis martinfleis added bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all. cg labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.9%. Comparing base (018f1e2) to head (72571b2).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #693     +/-   ##
=======================================
+ Coverage   84.7%   84.9%   +0.2%     
=======================================
  Files        141     141             
  Lines      15200   15206      +6     
=======================================
+ Hits       12880   12913     +33     
+ Misses      2320    2293     -27     
Files Coverage Δ
libpysal/cg/voronoi.py 72.5% <50.0%> (-0.7%) ⬇️

... and 6 files with indirect coverage changes

@jGaboardi
Copy link
Member

Is this something that might be fixed in the future upstream? If so, should we make a ticket here to check the behavior in the future? Or will the workaround continue to be functional after the upstream issue is resolved?

@martinfleis
Copy link
Member Author

I suppose it will be fixed in upstream. The if clause will be just skipped in that case, like it is in most cases where the issue does not happen right now. This is a very corner case but it was causing an issue when running enclosed_tessellation in momepy.

@jGaboardi jGaboardi merged commit 5a894c2 into pysal:main Mar 26, 2024
9 checks passed
@martinfleis martinfleis deleted the fix-geos-issue branch March 26, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all. cg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants