Add min arg to UserDefined #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGaboardi
approved these changes
Jul 25, 2021
martinfleis
reviewed
Jul 25, 2021
mapclassify/classifiers.py
Outdated
| lowest = mc.y.min() | ||
| if hasattr(mc, 'min'): | ||
| if mc.min: |
There was a problem hiding this comment.
Suggested change
| if mc.min: | |
| if mc.min is not None: |
Otherwise it wouldn't work for min=0.
mapclassify/classifiers.py
Outdated
| @@ -2256,9 +2266,10 @@ class UserDefined(MapClassifier): | |||
|
|
|||
| """ | |||
|
|
|||
| def __init__(self, y, bins): | |||
| def __init__(self, y, bins, min=None): | |||
There was a problem hiding this comment.
I'd rather use another keyword because now we're overriding built-in min(). Something like legend_min or lowest?
martinfleis
reviewed
Jul 25, 2021
mapclassify/classifiers.py
Outdated
| lowest = mc.y.min() | ||
| if hasattr(mc, 'lowest'): | ||
| if mc.lowest: |
There was a problem hiding this comment.
Suggested change
| if mc.lowest: | |
| if mc.lowest is not None: |
Just to ensure we don't forget about this. We need to be explicit to ensure it works for 0.
martinfleis
approved these changes
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #113