-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] lint & format repo; update CI; handle DeprWarns, etc. #128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
========================================
+ Coverage 78.0% 82.2% +4.2%
========================================
Files 12 7 -5
Lines 1936 1118 -818
========================================
- Hits 1511 919 -592
+ Misses 425 199 -226
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly okay to me, thanks!
Need to make sure these tests are all passing. Really weird that tests only failed for macOS Py3.10 (which is what I'm running locally, of course passing). Hopefully the additional random seed keywords solve the failures. |
"mostly okay" is not a ringing endorsement. LOL. Anything specific to change/not change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mostly okay" referred to that one comment I left in the code :).
This PR:
mapclassify
repoflake8
complainingflake8
as not usedclassifiers.MaxP
Still needs attention: (probably handle in a separate PR)
xref: geopandas/geopandas#2553