Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #132 #133

Merged
merged 1 commit into from
Oct 27, 2022
Merged

resolves #132 #133

merged 1 commit into from
Oct 27, 2022

Conversation

jGaboardi
Copy link
Member

resolves #132

@jGaboardi jGaboardi requested a review from martinfleis October 27, 2022 21:13
@jGaboardi jGaboardi self-assigned this Oct 27, 2022
martinfleis
martinfleis approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried to build the env and run notebook in there but the change looks okay.

@jGaboardi jGaboardi merged commit 47a90c2 into main Oct 27, 2022
@jGaboardi jGaboardi deleted the jGaboardi-patch-1 branch October 27, 2022 21:25
@jGaboardi jGaboardi mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

Assignees

@jGaboardi jGaboardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update binder environment
2 participants
@jGaboardi @martinfleis