remove numba cache from fisher jenks #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numba is writing cache to tmp file in
__pycache__
in the environment's site packages. If you install your conda env with admin rights and then try to run mapclassify with user rights, this will fail, as @jorisvandenbossche noticed while teaching.The cache is there to cache JIT-ted version of the function so it does not have to be compiled in a new Python runtime again. There's a lot of gotcha's in the docs for caching, plus the one above. I suppose that the benefit of caching is in the end smaller than the issues it may cause, so I am suggesting removing
cache=True
.