Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement rgbas #228

Merged
merged 9 commits into from
Jul 25, 2024
Merged

reimplement rgbas #228

merged 9 commits into from
Jul 25, 2024

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Jul 23, 2024

  • fixes a bug when the 'scheme' argument is passed
  • reimplement using matplotlib's vectorized method; much faster
  • give back numpy instead of lists

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.5%. Comparing base (af62513) to head (3f53485).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #228     +/-   ##
=======================================
- Coverage   89.6%   89.5%   -0.1%     
=======================================
  Files          9       9             
  Lines       1125    1127      +2     
=======================================
+ Hits        1008    1009      +1     
- Misses       117     118      +1     
Files Coverage Δ
mapclassify/util.py 88.0% <92.9%> (-3.3%) ⬇️

mapclassify/util.py Outdated Show resolved Hide resolved
mapclassify/util.py Outdated Show resolved Hide resolved
@knaaptime
Copy link
Member Author

updated and renamed with an example if @martinfleis or @sjsrey want to have a look

@knaaptime knaaptime merged commit 666accc into pysal:main Jul 25, 2024
20 checks passed
@knaaptime knaaptime deleted the colors branch July 25, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants