Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correction of JSONUnreadable error #19

Merged
merged 1 commit into from
Jan 5, 2019

Conversation

jGaboardi
Copy link
Member

This PR addressing #16, pysal/notebooks#52.

Corrected:

The notebook can now be open without issue, but not all cells can be run. Specific issues include:

  • an import of entropy, though I can't find where the package comes from
  • 'sm_glm' framework parameter from Gravity raises NotImplementedError.

@darribas
Copy link
Member

darribas commented Jan 5, 2019

Thanks very much @jGaboardi. I'm going to merge this in as it fixes the rendering error, but we can open another issue to make sure the notebook runs properly? To be honest, I didn't try to run all the notebooks pulled in for the book, so there might be more.

@darribas darribas merged commit 9121632 into pysal:master Jan 5, 2019
@jGaboardi jGaboardi deleted the glm_speed_notebook branch January 5, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants