Fix setting sample genotype using .alleles property #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, great stuff! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #891 .
The cause of the issue is that in
libcbcf.pyxthe@alleles.settermethod is identical to the@allele_indices.settermethod, while it should calculate the the allele indices and write these to the GT.I have included a test to check the correct behavior.
Additionally there is some code to allow the GT to be reset by passing
Nonean empty tuple or a(None,)tuple, and finally an assertion to check if no integers are passed to inform (potential) users which expect the old but incorrect behavior.