Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update deprecated 'Dataset.dims' usage to 'Dataset.sizes' #57

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

Aadarsh-Govada
Copy link
Collaborator

Description

The current usage of 'Dataset.dims' will soon be deprecated. The return type of Dataset.dims will be changed to return a set of dimension names in future, in order to be more consistent with DataArray.dims. This PR replaces the current uses of 'Dataset.dims' with 'Dataset.sizes'.

Type of change

Maintenance

How Has This Been Tested?

Test Configuration:

  • Operating system: GitHub Actions Ubuntu, Windows, and MacOS
  • Version number: Python 3.X

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@Aadarsh-Govada Aadarsh-Govada requested a review from jklenzing July 30, 2024 20:44
@jklenzing jklenzing merged commit 1831cc2 into develop Aug 1, 2024
22 checks passed
@jklenzing jklenzing deleted the future-warn branch August 1, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants