Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _cdf.py #28

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Update _cdf.py #28

merged 2 commits into from
Jan 21, 2021

Conversation

gregstarr
Copy link
Contributor

adding a try/except to _process_return_multi_z_attr when decoding characters so that when uninterpretable characters are encountered, they are just replaced with some filler character but the user can still access the data.

adding a try/except to `_process_return_multi_z_attr` when decoding characters so that when uninterpretable characters are encountered, they are just replaced with some filler character but the user can still access the data.
@gregstarr
Copy link
Contributor Author

see #26 for details

@gregstarr
Copy link
Contributor Author

Hello, just wanted to ping this issue

@rstoneback
Copy link
Collaborator

Hello, just wanted to ping this issue

Thanks for the reminder. Checking it out now.

@rstoneback
Copy link
Collaborator

rstoneback commented Jan 20, 2021

Changes to the latest Mac OS made it hard for me to get this compiled. The system prefers to use clang now instead of gcc. Had to track down a different machine.

I can confirm that pysatCDF can load SWARM L1B files as well as files it used to be able to load, like from C/NOFS VEFI.

I did also notice that to_pysat() function won't work for SWARM since measurement times are internally hard coded to 'epoch', rather than a user supplied string. to_pysat was originally designed for NASA's CDAWeb metadata standards. I'll post an issue #29

Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg. I added a suggested comment as a reminder for future developers.

Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending code comment.

adding comment to _cdf.py

Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
@gregstarr
Copy link
Contributor Author

Thanks for looking into this, I made the suggested changes.

@rstoneback rstoneback merged commit 20de52e into pysat:develop Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants