-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added a DMSP SSJ instrument #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the definition of the download stop time, not assuming it has a daily cadence.
Added an instrument for the DMSP SSJ auroral boundary data.
Added the DMSP SSJ instrument to the docs.
Added a summary of the changes to the changelog.
10 tasks
Requires pysat 3.1.0 release |
Because DMSP SSJ requires annual loading, it cannot be handled correctly by the general pandas instrument.
Fix CI docs tests with a sphinx version limit.
Updated the docstring and import style.
Attempt to update flake8 so PEP8 tests pass.
jklenzing
reviewed
Jun 1, 2023
Removed an extra blank line in a docstring.
Fixed variable names to lowercase, to comply with pysat standards.
jklenzing
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an instrument for the DMSP SSJ auroral boundary index data. This data is stored in yearly files, and requires an update to pysat to work correctly. It also revealed a local bug in the general download function.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Yields
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release