Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: GA updates #86

Merged
merged 9 commits into from
May 31, 2023
Merged

MAINT: GA updates #86

merged 9 commits into from
May 31, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented May 3, 2023

Description

Addresses pysat/pysat#1051. Because pip now builds a wheel locally (by default), it tries to download setuptools from test pypi, which isn't there.

Updates RC install options for work with pysat release candidates on test.pypi

Adds a new workflow to test install of the pysatMadrigal RC from test.pypi

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality or documentation)

How Has This Been Tested?

Running manual tests for the RC workflows.

Test Configuration

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have linted the files updated in this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release


name: Test install of latest RC from pip

on: [push]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on: [push]
on: [workflow_dispatch]

change before final merge

@jklenzing jklenzing requested a review from aburrell May 19, 2023 03:24
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that this test revealed the version wasn't attached correctly.

@jklenzing jklenzing requested a review from aburrell May 31, 2023 21:03
@aburrell aburrell added this to the 0.2.0 Release milestone May 31, 2023
@jklenzing jklenzing merged commit b465b50 into develop May 31, 2023
@jklenzing jklenzing deleted the tst/ga_updates branch May 31, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants