Skip to content

Conversation

@undingen
Copy link
Contributor

@undingen undingen commented Sep 2, 2015

                                7eec7fa2e53c908a06:  5c60ed7c85337bb516:
           django_template3.py             2.7s (4)             2.7s (4)  -0.6%
                 pyxl_bench.py             2.2s (4)             2.2s (4)  -1.3%
     sqlalchemy_imperative2.py             2.6s (4)             2.6s (4)  -1.4%
                       geomean                 2.5s                 2.5s  -1.1%

@undingen
Copy link
Contributor Author

undingen commented Sep 2, 2015

I'm not sure if we should not remove our __hasnext__ implementation because I think it doesn't give us as any advantage over tp_iternext which can just return NULL when it encountered the end!??

kmod added a commit that referenced this pull request Sep 2, 2015
add tp_nextiter implementation for our iterators
@kmod kmod merged commit 5963912 into pyston:master Sep 2, 2015
@kmod
Copy link
Collaborator

kmod commented Sep 2, 2015

nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants