Remove unneeded pyston workarounds + fix misc cpython test errors #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undingen
force-pushed
the
workarounds
branch
2 times, most recently
from
1568ff5 to
5ef005a
Compare
Contributor
Author
|
this sadly slowdowns pyxl by about 4%. Quick measurements show that about half of this is coming from adding weakref support to old style classes and the other part is coming from the collections.py change.. |
Collaborator
|
ah too bad about the slowdown. maybe we can punt on those particular issues for now and get the rest of it in? |
add list self assignment and list.index with non int args add thread._count copy over test_urllib2 from the correct python version
Contributor
Author
|
ooh I forgot about this PR... |
kmod
added a commit
that referenced
this pull request
Oct 15, 2015
Remove unneeded pyston workarounds + fix misc cpython test errors
Collaborator
|
nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.