Reduce the variability of the mypy benchmark #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first 2 runs of mypy read data from disk into a mypy-internal in-memory cache. This change attempts to reduce the impact of that I/O, which otherwise causes the results to have an excessively wide range. Additionally, since this makes the benchmark read as significantly "faster", this renames the benchmark so it would be accidentally compared with baselines against the old version. There is more discussion here: faster-cpython/ideas#543
|
Ah ok, good catch! |
|
I gave you access to this repo so you can merge your own PRs; I don't think I need to be a step in the process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first 2 runs of mypy read data from disk into a mypy-internal in-memory
cache. This change attempts to reduce the impact of that I/O, which otherwise
causes the results to have an excessively wide range.
Additionally, since this makes the benchmark read as significantly "faster",
this renames the benchmark so it would be accidentally compared with baselines
against the old version.
There is more discussion here: faster-cpython/ideas#543