Add DSL docs and update bootstrap project #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-blanchard
changed the title
|
I believe I've finally got all the relevant DSL things updated for the preview release. You can see this branch on RTD (if you have the direct link) here. |
|
Bah, forgot the stupid quickstart instructions. Doing those now. |
|
Okay, now it's good. |
|
Add method link to :meth:`~...emit_direct` |
| You must either specify this, or | ||
| both ``full_class_name`` and ``args_list``. | ||
| :type serialized_java: `bytes` | ||
| :param full_class_name: Full name of Java class, including namespaces. |
There was a problem hiding this comment.
I suppose that "including namespaces" makes sense to a Python developer, but a Java developer would think of it as "fully qualified class name, i.e. include the package name".
|
This looks great. I added some minor comments. Once addressed, +1 to merge. |
dan-blanchard
force-pushed
the
feature/dsl_docs
branch
from
3259a7f to
dc05392
Compare
dan-blanchard
added a commit
that referenced
this pull request
Mar 11, 2016
Add DSL docs and update bootstrap project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is good enough for a preview release now.
Rendered docs available on RTD here