Set submit options via config.json #265
Conversation
Set additional option and worker/acker count via config.json
| if isinstance(options, dict): | ||
| additional_options.update(options) | ||
| options = additional_options | ||
| if not workers: |
There was a problem hiding this comment.
This should never happen, as the defaults for this method set it to 2.
There was a problem hiding this comment.
Oh, a brief explanation:
In our custom fork of this file, I've set defaults of the method to None, to be able check if something was passed or not (since there could be passed 2 as well). But it turned out, that it is set to 2, even though the defaults are None.
I wanted to leave precedence to CLI arguments before config.json options, but it turned out, that there is always passed number 2 to this method (from outside), even with no -p (or similar option) used.
So I'm trying to find a way to ensure that defaults < config.json < CLI args.
Which I was not able to do so far.
|
Thanks for the PR! This will definitely come in handy. |
Set additional option and worker/acker count via config.json