upload jar before killing existing topology #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we kill the topology before uploading the jar, the topology stays disabled until the upload is complete. on a slow network, this can lead to the topology being disabled for an unacceptably long time during the deployment. additionally, if the upload fails and deployment crashes, this change will ensure that it did not have a destructive effect on the existing topology.
|
Thanks for the great simpler PR. This will be a big win on slow connections, like you said. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we kill the topology before uploading the jar, the topology stays disabled until the upload is complete. on a slow network, this can lead to the topology being disabled for an unacceptably long time during the deployment. additionally, if the upload fails and deployment crashes, this change will ensure that it did not have a destructive effect on the existing topology.