Allow empty outputs #292
Merged
Allow empty outputs #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the problem was introduced here. |
| @@ -194,6 +194,8 @@ def _spec_to_flux_dict(spec): | |||
| shell_object = spec.component_object.shell | |||
| flux_dict['constructorArgs'].append([shell_object.execution_command, | |||
| shell_object.script]) | |||
| if not spec.outputs or len(spec.outputs) == 0: | |||
There was a problem hiding this comment.
Super minor nitpick, but could you please get rid of the or len(spec.outputs) == 0 from this line? It's unnecessary, because if spec.outputs is empty, not spec.outputs will be true.
There was a problem hiding this comment.
Your are right. Done.
|
Thanks for the pull request! |
Removed unreachable check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flux expects at least one output if fails on not defined or empty
spec.outputs. Since empty outputs were supported in all 3.0.0-dev releases this breaks a lot of recent code.