Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add graphviz to requirements file #311

Closed
wants to merge 1 commit into from

Conversation

gallamine
Copy link
Contributor

@gallamine gallamine commented Sep 1, 2016

Tried to sparse kill after 3.0.1 upgrade and got the following error:

sparse kill -n <name> -e preprod
Traceback (most recent call last):
  File "/Users/william/anaconda/envs/ds_storm_topologies/bin/sparse", line 11, in <module>
    sys.exit(main())
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/site-packages/streamparse/cli/sparse.py", line 51, in main
    load_subparsers(subparsers)
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/site-packages/streamparse/cli/sparse.py", line 27, in load_subparsers
    module = importlib.import_module('streamparse.cli.{}'.format(mod_name))
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/site-packages/streamparse/cli/visualize.py", line 19, in <module>
    raise ImportError('The visualize command requires the `graphviz` Python '
ImportError: The visualize command requires the `graphviz` Python library and `graphviz` system library to be installed.

Pip installing graphviz fixed this issue.

Tried to `sparse kill` after 3.0.1 upgrade and got the following error:

```sparse kill -n <name> -e preprod
Traceback (most recent call last):
  File "/Users/william/anaconda/envs/ds_storm_topologies/bin/sparse", line 11, in <module>
    sys.exit(main())
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/site-packages/streamparse/cli/sparse.py", line 51, in main
    load_subparsers(subparsers)
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/site-packages/streamparse/cli/sparse.py", line 27, in load_subparsers
    module = importlib.import_module('streamparse.cli.{}'.format(mod_name))
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/Users/william/anaconda/envs/ds_storm_topologies/lib/python2.7/site-packages/streamparse/cli/visualize.py", line 19, in <module>
    raise ImportError('The visualize command requires the `graphviz` Python '
ImportError: The visualize command requires the `graphviz` Python library and `graphviz` system library to be installed.```

Pip installing graphviz fixed this issue.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.821% when pulling 674904b on gallamine:patch-1 into 30c6d70 on Parsely:master.

@dan-blanchard
Copy link
Member

Thanks for the PR! I'd actually rather make sure that graphviz is optional for people who don't want to use the sparse visualize command, so I fixed it in 5e94744. Will push 3.1.1 to PyPI momentarily.

This is why I should always do an install into a fresh virtualenv before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants