Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pip 9.x when setting up virtualenv so we can use upgrade-strategy #327

Merged
merged 1 commit into from
Nov 3, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion streamparse/cli/update_virtualenv.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ def _create_or_update_virtualenv(virtualenv_root,
puts("Updating virtualenv: {}".format(virtualenv_name))
cmd = "source {}".format(os.path.join(virtualenv_path, 'bin/activate'))
with prefix(cmd):
run("pip install -r {} --exists-action w".format(tmpfile))
# Make sure we're using latest pip so options work as expected
run("pip install --upgrade 'pip~=9.0'")
run("pip install -r {} --exists-action w --upgrade "
"--upgrade-strategy only-if-needed".format(tmpfile))

run("rm {}".format(tmpfile))

Expand Down