Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in the neighborhood module #23

Closed
devendragovil opened this issue Sep 21, 2023 · 3 comments
Closed

Bug in the neighborhood module #23

devendragovil opened this issue Sep 21, 2023 · 3 comments
Assignees
@mhajij

Comments

@devendragovil
Copy link
Contributor

What

There is a bug in this part of the neighborhood_from_complex method of the neighborhood module:
image

Both the cases for neighborhood_type lead to an error because the ranks (rank and via_rank) are incorrect.
@mhajij mhajij self-assigned this Sep 28, 2023
@mhajij
Copy link
Member

mhajij commented Sep 28, 2023

@devendragovil can you check in the main branch now solve the problem ?

@gurug-dev gurug-dev mentioned this issue Sep 28, 2023
Merged
@gurug-dev gurug-dev removed their assignment Sep 28, 2023
@mhajij
Copy link
Member

mhajij commented Sep 29, 2023

@devendragovil I think I addressed that? can you please doublecheck and close the issue if you think it is done.

@devendragovil
Copy link
Contributor Author

@mhajij Can confirm that there is no error being thrown now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhajij mhajij

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devendragovil @mhajij @gurug-dev