Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tutorial #26

Merged
merged 5 commits into from
Sep 28, 2023
Merged

adding tutorial #26

merged 5 commits into from
Sep 28, 2023

Conversation

mhajij
Copy link
Member

@mhajij mhajij commented Sep 28, 2023

adding DeepCell tutorial and fixing some docstring, making it more clear

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ba7a91e) 90.47% compared to head (ffbcc48) 90.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files           7        7           
  Lines         105      105           
=======================================
  Hits           95       95           
  Misses         10       10           
Files Coverage Δ
topoembedx/classes/cell2vec.py 100.00% <ø> (ø)
topoembedx/classes/cell_diff2vec.py 58.82% <ø> (ø)
topoembedx/classes/deepcell.py 100.00% <ø> (ø)
...embedx/classes/higher_order_laplacian_eigenmaps.py 100.00% <ø> (ø)
topoembedx/classes/hoglee.py 100.00% <ø> (ø)
topoembedx/neighborhood.py 75.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos: e.g. parmater
DeepCell.ipynb --> deepcell.ipynb to respect python guidelines in naming files.

@mhajij
Copy link
Member Author

mhajij commented Sep 28, 2023

@ninamiolane lint is failing in the tutorial should we disable that there or what actions do you recommend ?

@mhajij mhajij requested a review from ninamiolane September 28, 2023 20:12
@ninamiolane
Copy link
Collaborator

@mhajij run black . in your command line.

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the tutorial is awesome!! Thanks!

@ninamiolane ninamiolane merged commit ce5dff8 into main Sep 28, 2023
@ninamiolane ninamiolane deleted the tutorial branch September 28, 2023 20:42
@gurug-dev
Copy link

gurug-dev commented Sep 28, 2023

this PR also includes fixes for #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants