Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the hoan layer #226

Closed
wants to merge 1 commit into from
Closed

fix the hoan layer #226

wants to merge 1 commit into from

Conversation

mhajij
Copy link
Member

@mhajij mhajij commented Sep 28, 2023

fixing hoan layer

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mhajij
Copy link
Member Author

mhajij commented Sep 28, 2023

@ninamiolane tests run on local machine but not here, any idea why?

Copy link
Collaborator

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhajij this branch is not correctly sync with the main branch. For example, the changes on test.yml are already merged in the main branch and should not be part of this PR.

@ninamiolane ninamiolane marked this pull request as draft September 28, 2023 14:19
@mhajij
Copy link
Member Author

mhajij commented Sep 28, 2023

is being handled elsewhere

@mhajij mhajij closed this Sep 28, 2023
@levtelyatnikov levtelyatnikov deleted the hoan branch October 18, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants