-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old sparse -> dense -> sparse with new from_sparse method #235
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 58 58
Lines 2230 2230
=======================================
Hits 2153 2153
Misses 77 77
☔ View full report in Codecov by Sentry. |
Tests need to pass before we can review. See failures here: |
@ninamiolane Thank you for taking a look. I was about to tag you and @mhajij for your thoughts. There's a weird issue in can_train tutorial that I've been working on since yesterday. TLDR. can_layer errors when accessing index of the sparse matrix. So need to call coalesce before that. But then it's causing a matrix dimension mismatch in MultiHeadLiftLayer during training which made me suspicious of something deeper going on:
So I'm tracing the source of the issue, identifying the matrix. It's taking me longer since I'm not familiar with CAN architecture. Will keep you posted. |
@ninamiolane @mhajij I created a new ticket where I documented the details issue #236 |
ce1275e
to
5118ee2
Compare
Replaces all sparse torch casting to new method
from_sparse
except in 1 example where there's an issue #236 that's been documented.