Move datasets to atomlists #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffl096
force-pushed
the
frantzen/dataset-overhaul
branch
from
b3a4abd to
583e597
Compare
ffl096
force-pushed
the
frantzen/dataset-overhaul
branch
from
583e597 to
98623ff
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 97.77% 97.83% +0.05%
==========================================
Files 38 38
Lines 3556 3558 +2
==========================================
+ Hits 3477 3481 +4
+ Misses 79 77 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, we move the
cosegandshrec16datasets from apicklebackend to atomlists. We need this change because thepickleapproach relies on internal data structures to not change, which is a blocker for #220. Plus, it is highly unstable anyway.