Check for AugAssign in parse_edge_z3_constraints #1087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for AugAssign statement and handle reassigned variables Create unit test for AugAssign Update change log
Pull Request Test Coverage Report for Build 10986682105Details
💛 - Coveralls |
There was a problem hiding this comment.
@Raine-Yang-UofT this is good. Since you're extending this anyway, the third type of assignment node in astroid is AnnAssign, could you please add to this PR to handle those nodes as well?
| @@ -467,18 +467,25 @@ def func(x: int, y: int) -> None: | |||
|
|
|||
| def test_variable_reassignment() -> None: | |||
There was a problem hiding this comment.
Rather than add to this test case, a better approach is to create a separate test case (to better isolate the new functionality being tested).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Check for
AugAssignnode as variable reassignment statements in creating CFG edge z3 constraints....
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)