-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created InvalidNameChecker #931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages when reporting on names that violate Python naming conventions
sushimon
force-pushed
the
invalid-name-checker
branch
from
July 21, 2023 05:09
8484fcc
to
2336229
Compare
…efore version 3.10
Pull Request Test Coverage Report for Build 5675839692
💛 - Coveralls |
sushimon
force-pushed
the
invalid-name-checker
branch
from
July 27, 2023 02:08
eb9a8f4
to
a27ab6e
Compare
sushimon
force-pushed
the
invalid-name-checker
branch
from
July 27, 2023 02:24
a27ab6e
to
6047948
Compare
david-yz-liu
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Pylint's
invalid-name
error explains how a variable name violates conventions but does so using regular expressions. Since beginners are unlikely to know what regular expressions are, this PR aims to "extend" the behaviour of theinvalid-name
checker by providing more beginner-friendly error messages.Your Changes
Description:
CHANGELOG.md
file.invalid-name
in the config file to avoid redundant checks.Type of change (select all that apply):
Testing
CHANGELOG.md
and verified the newly added documentation is there.Questions and Comments (if applicable)
The failing test on GitHub Actions passes locally. The appropriate message gets added properly locally.Checklist