Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new optional initialization argument output to AccumulationTable #988

Merged
merged 20 commits into from
Dec 10, 2023

Conversation

AinaMerch
Copy link
Contributor

Add a new optional initialization argument output to AccumulationTable. This argument is either be None (default), or a string representing a filepath. If a filepath is provided, the AccumulationTable writes its table to that file rather than to standard output

Motivation and Context

Adds additional functionality as described above.

Your Changes

Modified accumulation_table.py to implement functionality and added tests in test_accumulation_table.py

Description:

Type of change (select all that apply):

  • New feature (non-breaking change which adds functionality)
  • Documentation update (change that modifies or updates documentation only)

Testing

Wrote tests in the test file.
Manually tested on different functions in different situations.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have added tests for my changes.
  • I have updated the CHANGELOG.md file.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7145297637

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.604%

Totals Coverage Status
Change from base Build 7123781450: 0.0%
Covered Lines: 3419
Relevant Lines: 3614

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 42cb284 into pyta-uoft:master Dec 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants