-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new optional initialization argument output to AccumulationTable #988
Merged
david-yz-liu
merged 20 commits into
pyta-uoft:master
from
AinaMerch:new-config-accumulation-table
Dec 10, 2023
Merged
Add a new optional initialization argument output to AccumulationTable #988
david-yz-liu
merged 20 commits into
pyta-uoft:master
from
AinaMerch:new-config-accumulation-table
Dec 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulation-table-bug-fix
…onfig-accumulation-table
Pull Request Test Coverage Report for Build 7145297637
💛 - Coveralls |
david-yz-liu
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new optional initialization argument output to AccumulationTable. This argument is either be None (default), or a string representing a filepath. If a filepath is provided, the AccumulationTable writes its table to that file rather than to standard output
Motivation and Context
Adds additional functionality as described above.
Your Changes
Modified accumulation_table.py to implement functionality and added tests in test_accumulation_table.py
Description:
Type of change (select all that apply):
Testing
Wrote tests in the test file.
Manually tested on different functions in different situations.
Questions and Comments (if applicable)
Checklist