Skip to content

Conversation

@hmgaudecker
Copy link
Contributor

Triviality that I noted while actually trying to follow that link in an application.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #306 (e54e121) into main (1413a62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files          91       91           
  Lines        7771     7771           
=======================================
  Hits         7517     7517           
  Misses        254      254           
Flag Coverage Δ
end_to_end 82.84% <ø> (ø)
integration 41.01% <ø> (ø)
unit 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/warnings.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hmgaudecker
Copy link
Contributor Author

While actually looking at that page: Is the exact syntax described somewhere? After parsing the examples, my best guess before actually trying is

action:regex:warningtype

but it would be nice to have that written out explicitly.

Aside: Explanation of the order in which they are processed would be good. From the described behaviour, I suppose that latter items take precedence over former items in the list?

@hmgaudecker
Copy link
Contributor Author

I re-ordered the section a little bit. At least for an old person like me, parsing the example was very hard because the respective order of the text and the code did not line up. Hope it works like this.

@tobiasraabe
Copy link
Member

Thanks! It is better now.

@hmgaudecker
Copy link
Contributor Author

Cool. LMK if there is anything else you want me to do before merging this!

@tobiasraabe tobiasraabe changed the title Fix typo in link. Fix typo in link and adjust documentation for warnings. Oct 21, 2022
@tobiasraabe tobiasraabe self-requested a review October 21, 2022 09:00
Copy link
Member

@tobiasraabe tobiasraabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all good. Thank you very much!

@tobiasraabe tobiasraabe merged commit e3c1a4c into main Oct 21, 2022
@tobiasraabe tobiasraabe deleted the fix_typo_in_link branch October 21, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants