Skip to content

Conversation

@tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Oct 28, 2020

  • Remove -m flag for passing mode to pytask clean because it conflicts with marker expressions.
  • Add check when tasks have the same product.
  • Allow to pass dependencies and products as dictionaries.

@tobiasraabe tobiasraabe added this to the v0.0.9 milestone Oct 28, 2020
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #38 into main will increase coverage by 0.26%.
The diff coverage is 98.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   88.66%   88.93%   +0.26%     
==========================================
  Files          53       53              
  Lines        4174     4292     +118     
==========================================
+ Hits         3701     3817     +116     
- Misses        473      475       +2     
Flag Coverage Δ
#end_to_end 74.88% <87.34%> (+0.39%) ⬆️
#integration 40.42% <30.12%> (-0.36%) ⬇️
#unit 67.91% <74.09%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/_pytask/collect_command.py 80.00% <ø> (ø)
tests/test_clean.py 100.00% <ø> (ø)
src/_pytask/report.py 98.96% <93.33%> (-1.04%) ⬇️
src/_pytask/nodes.py 96.89% <98.11%> (+0.34%) ⬆️
src/_pytask/clean.py 89.43% <100.00%> (ø)
src/_pytask/collect.py 94.40% <100.00%> (+0.33%) ⬆️
src/_pytask/parametrize.py 100.00% <100.00%> (ø)
src/_pytask/resolve_dependencies.py 98.11% <100.00%> (+0.28%) ⬆️
src/_pytask/session.py 100.00% <100.00%> (ø)
src/_pytask/shared.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7e1ac...71f24c6. Read the comment docs.

@tobiasraabe tobiasraabe merged commit 11d18f2 into main Oct 28, 2020
@tobiasraabe tobiasraabe deleted the allow-dictionaries branch October 28, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants