Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of names and signatures of PythonNodes. #482

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

tobiasraabe
Copy link
Member

@tobiasraabe tobiasraabe commented Nov 8, 2023

No description provided.

@tobiasraabe tobiasraabe added this to the v0.4.2 milestone Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e39b68) 96.40% compared to head (7439f7a) 96.41%.

❗ Current head 7439f7a differs from pull request most recent head 3a91f23. Consider uploading reports for the commit 3a91f23 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   96.40%   96.41%   +0.01%     
==========================================
  Files         104      104              
  Lines        8806     8836      +30     
==========================================
+ Hits         8489     8519      +30     
  Misses        317      317              
Flag Coverage Δ
end_to_end 82.75% <100.00%> (+0.04%) ⬆️
integration 40.49% <25.71%> (-0.07%) ⬇️
unit 67.72% <48.57%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/_pytask/_hashlib.py 100.00% <100.00%> (ø)
src/_pytask/collect.py 94.05% <100.00%> (+0.05%) ⬆️
src/_pytask/collect_utils.py 99.01% <100.00%> (ø)
src/_pytask/nodes.py 89.28% <100.00%> (+0.07%) ⬆️
tests/test_collect_command.py 100.00% <100.00%> (ø)
tests/test_execute.py 99.25% <100.00%> (+0.02%) ⬆️
tests/test_nodes.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasraabe tobiasraabe changed the title Fix handling of names and signatures of PythonNodes. Fix handling of names and signatures of PythonNodes. Nov 8, 2023
@tobiasraabe tobiasraabe merged commit 7592664 into main Nov 8, 2023
18 checks passed
@tobiasraabe tobiasraabe deleted the fix-python-node-name branch November 8, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant