CI: remove unneeded install of graphviz on ubuntu #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo of `ubunut` so this blockw as never getting run. See https://github.com/pytask-dev/pytask/actions/runs/7092233325/job/19303082025 Guess it wasn't needed! Does this mean the macos block can get deleted too?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 96.50% 96.60% +0.10%
==========================================
Files 104 104
Lines 8920 8920
==========================================
+ Hits 8608 8617 +9
+ Misses 312 303 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for finding this. The |
|
Ah, I see the distinction. Graphviz SHOULD be needed, we just weren't catching it because the tests weren't getting run. Nice fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo of
ubunutso thisblockw as never getting run.
See https://github.com/pytask-dev/pytask/actions/runs/7092233325/job/19303082025
Guess it wasn't needed!
Does this mean the macos block can get deleted too?
Changes
Provide a description and/or bullet points to describe the changes in this PR.
Todo