Error checking on Post Versions

tentd/blueprints/posts.py

@@ -32,6 +32,9 @@ def post(self):
  TODO: Separate between apps creating a new post and a notification
  from a non-followed entity.
  """
+ if 'received_at' in request.json:
+ raise APIBadRequest("You may not set received_at on a post")
+
  post = Post(entity=g.entity, schema=request.json.pop('schema'))
  post.new_version(**request.json)
  post.save()

tentd/tests/blueprints/test_posts.py

@@ -2,9 +2,12 @@
 
 from json import dumps
 
+from flask import url_for
+
 from tentd.documents.entity import Post
 from tentd.flask import jsonify
 from tentd.tests import EntityTentdTestCase
+from tentd.utils import time_to_string
 
 class PostTests(EntityTentdTestCase):
  """Tests relating to the post routes."""
@@ -134,8 +137,20 @@ def test_delete_post_version(self):
 
 class MorePostsTest(EntityTentdTestCase):
  """Tests for posts without having existing posts."""
- def test_entity_get_empty_posts(self):
+ def test_create_invalid_post(self):
+ response = self.client.post(
+ url_for('posts.posts', entity=self.entity),
+ data=dumps({
+ 'content': "Hello world",
+ 'received_at': time_to_string('now')}))
+
+ self.assertStatus(response, 400)
+ self.assertJSONError(response)
+
+ def test_get_empty_posts(self):
  """Test that /posts works when there are no posts to return"""
- resp = self.client.get('/{}/posts'.format(self.name))
- self.assertStatus(resp, 200)
- self.assertEquals(resp.json(), [])
+ response = self.client.get(
+ url_for('posts.posts', entity=self.entity))
+
+ self.assertStatus(response, 200)
+ self.assertEquals(response.json(), [])

tentd/utils/__init__.py

@@ -1,5 +1,6 @@
 """Miscellaneous utilities for pytentd"""
 
+from datetime import datetime
 from functools import wraps
 from time import mktime
 
@@ -45,6 +46,8 @@ def json_attributes(obj, *names, **kwargs):
  json.update(kwargs)
  return json
 
-def time_to_string(time_field):
+def time_to_string(time):
  """Converts a datetime instance to a string"""
- return mktime(time_field.timetuple())
+ if time is None: return time
+ if time == "now": time = datetime.now()
+ return mktime(time.timetuple())