waitclose in _rinfo() call #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Jan 26, 2021
|
@webknjaz maybe we should disable windows and py3.4 for now? |
|
I guess py34 should be deprecated along with py2 since xdist no longer supports those anyway |
|
@graingert master is green so you could just rebase now |
should improve pytest-dev/pytest-xdist#620
graingert
force-pushed
the
waitclose-in-rinfo-call
branch
from
7ad0fb9
to
84ffea8
Compare
|
Thanks a lot @graingert! |
|
|
zmedico
reviewed
Feb 25, 2024
| try: | ||
| self._cache_rinfo = RInfo(ch.receive()) | ||
| finally: | ||
| ch.waitclose() |
There was a problem hiding this comment.
Since the waitclose doesn't elicit any response to guarantee that the main thread has been released, I added a one second timeout for it to release as shown in #243 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should improve pytest-dev/pytest-xdist#620