-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff in place of black and reorder-python-imports #239
Conversation
Unfortunately black and reorder-python-imports are no longer compatible between each other: asottile/reorder-python-imports#367 asottile/reorder-python-imports#366 psf/black#4175 Take this opportunity to try out ruff.
I realized later that |
Ruff does implement isort but it needs to be enabled: Rule: https://docs.astral.sh/ruff/rules/unsorted-imports/ |
Thanks @bluetech, even better then! 👍 |
I haven't checked myself, but are you sure the isort part works? The [tool.ruff.lint]
extend-select = ["I001"] ( |
TBH no, I will double check later, thanks for raising it. |
As brought up in pytest-dev#239 (comment), the isort settings for ruff were not being applied.
As brought up in #239 (comment), the isort settings for ruff were not being applied.
Unfortunately black and reorder-python-imports are no longer compatible between each other:
asottile/reorder-python-imports#367
asottile/reorder-python-imports#366
psf/black#4175
Take this opportunity to try out ruff.
Closes #231.