Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions #18

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 20, 2021

Travis CI is being turned off for the pytest-dev org (internal discussion), due to the recent security handling (1, 2).

This PR replaces Travis CI with GitHub Actions. It mostly replicates the old Travis workflow, the main differences is it runs using tox and adds caching.

And just like the last Travis build, it also fails for Python 3.8. I didn't look into it but it's a known issue so we have parity.

I also noticed that Python 3.7.1 (the last Travis CI build) and 3.7.7 (what I have on my machine) passed, but the latest 3.7 version on GHA (3.7.12) failed. So I've pinned to 3.7.7 in the CI. #15 (comment) also noted 3.7 failed, so this will need checking in the future (as part of #15).

Also, drop support for Python 3.4, it's not available on GHA, and anyway is EOL. We should also drop EOL 3.5 too. Shall I also remove it here?

Also, update Trove classifiers.

Finally, drop the dot in py.test :) https://twitter.com/pytestdotorg/status/753767547866972160

@hugovk
Copy link
Member Author

hugovk commented Sep 20, 2021

Here's an example build:

https://github.com/hugovk/nose2pytest/actions/runs/1254263380

Please could someone enable GHA for this repo at https://github.com/pytest-dev/nose2pytest/actions?

@nicoddemus
Copy link
Member

Please could someone enable GHA for this repo at pytest-dev/nose2pytest/actions?

Hmm how? Just create a dummy Python workflow?

Because I'm happy to just merge this and fix anything not working as it should afterward.

@hugovk
Copy link
Member Author

hugovk commented Sep 20, 2021

If there's no big "Enable Actions button" at https://github.com/pytest-dev/nose2pytest/actions, then let's just merge and fix from there! Thanks!

@nicoddemus
Copy link
Member

Yeah I don't see anything like that. 😁

Merging, thanks a lot for tackling this. 👍

@nicoddemus nicoddemus merged commit 758b27a into pytest-dev:master Sep 20, 2021
@nicoddemus
Copy link
Member

Running: https://github.com/pytest-dev/nose2pytest/actions/runs/1254290050 👍

@hugovk hugovk deleted the replace-travis-with-gha branch September 20, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants