Remove deprecated implprefix support #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
approved these changes
Jun 5, 2020
There was a problem hiding this comment.
Big 💯 from me.
@RonnyPfannschmidt should probably give this a serious once over.
RonnyPfannschmidt
approved these changes
Jun 5, 2020
|
Added "Fixes #145" to the PR description, missed it when I submitted the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been deprecated for a while, let's remove it in pluggy 1.0.
Refs #116. Fixes #145.
pytest no longer uses it.
tox doesn't use it.
devpi mentions it with comment "support old plugins, but emit deprecation warnings", does so in a future-compatible manner however (doesn't pass the
implprefixargument toPluginManager, which this PR removes, but sets_implprefixattribute instead, which this PR now ignores). devpi usespluggy>=0.6.0,<1.0so it's fine anyway.