Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #81: Stop using 'inspect.getargspec()' #94

Merged
merged 2 commits into from
Nov 24, 2017

Commits on Oct 29, 2017

  1. Fix pytest-dev#81: Stop using 'inspect.getargspec()'

    This function is deprecated and raises the warning.
    
      DeprecationWarning: inspect.getargspec() is deprecated, use
      inspect.signature() instead
    
    While this suggests we use 'inspect.signature()', there's no reason to
    use this instead of the 'inspect.getfullargspec()', which has almost
    identical semantics to 'inspect.getargspec()' but handles kwargs-only
    functions. For what we want though, this is a drop-in replacement.
    
    Note that because 'inspect.getfullargspec()' isn't provided in Python
    2.7, we may see slightly different behavior between Python 2 and 3 (e.g.
    for the kwargs-only case above).  There's nothing we can do about this
    without vendoring the entire function.
    
    Signed-off-by: Stephen Finucane <stephen@that.guru>
    stephenfin committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    5758ba0 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2017

  1. Configuration menu
    Copy the full SHA
    451515a View commit details
    Browse the repository at this point in the history