'LocalPath.samefile' should normalize the path

[pytestbot]

• Bitbucket: https://bitbucket.org/pytest-dev/py/issue/58
• Originally reported by: @vladipus
• Originally created at: 2015-02-27T19:02:57.723

The 'LocalPath.samefile' method should normalize the path on MS Windows, since it can contain back slahes.
Otherwise, I'm getting the following error in (my currently loved of which I'm thankful to you) pytest system:

Traceback (most recent call last):
File "C:\msys64\mingw64\lib\python2.7\site-packages/_pytest/config.py", line 543, in importconftest
mod = conftestpath.pyimport()
File "C:\msys64\mingw64\lib\python2.7\site-packages\py/_path/local.py", line 664, in pyimport
  raise self.ImportMismatchError(modname, modfile, self)
ImportMismatchError: ('conftest', 'C:\\secret-project\\tests/conftest.py', local('C:\\secret-project\\tests\\conftest.py'))

Suggested fix:

def samefile(self, other):
    """ return True if 'other' references the same file as 'self'.
    """
    other = getattr(other, "strpath", other)
    if not isabs(other):
        other = abspath(other)
    if self == other:
        return True
    if iswin32:
        # Convert possible forward slashes to back.
        if self == normpath(other):
            return True
        else:
            return False # there is no samefile
    return py.error.checked_call(
            os.path.samefile, self.strpath, other)

[pytestbot]

Original comment by @vladipus

I have created a PR with the change - https://bitbucket.org/pytest-dev/py/pull-request/28

[pytestbot]

Original comment by @vladipus

Got this error once again, today. What kind of test are you looking for? The scenario is as that: install an MSys2 environment, Python and pytest. Then, try running the tests like::

if __name__ == '__main__':
  import pytest
  pytest.main()

The path on Windows should be normalized before comparing like that self == other, because a Windows path may use back slashes in its paths and are semantically equal to forward slashes.

Thank you.

[pytestbot]

Original comment by @vladipus

Got no time for this currently. Maybe later. The fix is trivial and self-explanatory. I understand and respect your test-driven approach however.

[pytestbot]

Original comment by @hpk42

can you submit a PR which includes a test that fails on windows?

[RonnyPfannschmidt]

@rafaelpivato any interest in resuming this?

[blueyed]

Is this still an issue?
The code has changed in this regard (e.g. ef37a06).

[RonnyPfannschmidt]

i dont think its the same chagne