Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for current Python 3.12 #798

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Mar 29, 2023

  • adapt for changed pathlib implementation (removed flavour implementation)
  • Windows: add patching for some os.path functions now implemented in nt instead of ntpath
  • fix handling of devnull for changed OS
  • add fake implementation for os.path.splitroot
  • fixes Fake pathlib not working with Python 3.12-dev #770

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing

- adapt for changed pathlib implementation (removed flavour implementation)
- Windows: add patching for some os.path functions now implemented in nt instead of ntpath
- fix handling of devnull for changed OS
- add fake implementation for os.path.splitroot
- fixes pytest-dev#770
@mrbean-bremen mrbean-bremen merged commit 199561f into pytest-dev:main Mar 30, 2023
@mrbean-bremen mrbean-bremen deleted the python3.12 branch March 30, 2023 19:30
@@ -17,6 +17,8 @@ The released versions correspond to PyPI releases.
### Features
* added possibility to set a path inaccessible under Windows by using `chown()` with
the `force_unix_mode` flag (see [#720](../../issues/720))
* added support for changes in Python 3.12 (currently in last beta version)
Copy link
Member

@hugovk hugovk Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.12 is currently on alpha 6, with alpha 7 due on Monday and beta 1 due in May:

https://peps.python.org/pep-0693/#schedule

But thank you for this fix! It will make it easier for libraries to test against 3.12 and be ready for the full release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I actually meant to write "last alpha version" - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fake pathlib not working with Python 3.12-dev
2 participants