Handle bound fixture methods correctly #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
force-pushed
the
async_fixture_methods
branch
7 times, most recently
from
cef53c9 to
e69738a
Compare
seifertm
force-pushed
the
async_fixture_methods
branch
from
e69738a to
6188089
Compare
|
The CI runs the tests with |
seifertm
requested changes
Nov 10, 2022
When the current test request references an instance, bind the fixture function to that instance. When the unittest flag is set, this happens unconditionally, otherwise only if: - the fixture wasn't bound already - the fixture is bound to a compatible instance (the request.instance object has the same type or is a subclass of that type). This follows what pytest does in such cases, exactly.
mjpieters
force-pushed
the
async_fixture_methods
branch
from
6188089 to
8860dc5
Compare
mjpieters
requested review from
seifertm
and removed request for
Tinche and
asvetlov
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passed a bound fixture method, re-bind that method to the currently active instance.
The implementation follows how pytest handles bound fixtures, including how it'll always bind any fixture when
fixturedef.unittestis true, and otherwise only if the fixture wasn't already bound or if bound to a an instance of the same class or a subclass thereof.Fixes #197